Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate boundary_conditions argument to model constructors #3788

Open
glwagner opened this issue Sep 25, 2024 · 0 comments
Open

Validate boundary_conditions argument to model constructors #3788

glwagner opened this issue Sep 25, 2024 · 0 comments

Comments

@glwagner
Copy link
Member

Cause stuff like

model = HydrostaticFreeSurfaceModel(; grid, coriolis, boundary_conditions = (; u_bcs))

doesn't fail, it just doesn't actually apply boundary conditions to u (which was intended here).

In the past we've allowed some fairly complex input. So maybe we can just pass a warning when keys of boundary_conditions are not prognostic fields. Even more neutral would be error if none of the keys are prognostic fields (which would still catch the issue above but could miss some other annoying typos).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant