Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify imex ark #254

Open
charleskawczynski opened this issue Feb 27, 2024 · 0 comments
Open

Simplify imex ark #254

charleskawczynski opened this issue Feb 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@charleskawczynski
Copy link
Member

I think we could simplify imex ark. An attempt was made in #212, but there were some issues (also, #225 is a blocker to all of the annotations).

But the basic idea is nice: re-write the code such that we have:

for i in 1:N_implicit
 # do explicit
 # do implicit
end

 # do final explicit

It would be nice to have a clearer separation of the stages. Also, right now, there are a few things that appear to happen near the end, but due to empty ranges doing nothing (for i in 1:0; # work; end does no work ), code at the end of stage_update! is what actually gets executed first, which is confusing. The hard-coded ARS343 is a really nice piece of code to compare against.

@charleskawczynski charleskawczynski added the enhancement New feature or request label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant