Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt in post_explicit! and post_implicit! #231

Open
Sbozzolo opened this issue Oct 13, 2023 · 0 comments
Open

dt in post_explicit! and post_implicit! #231

Sbozzolo opened this issue Oct 13, 2023 · 0 comments

Comments

@Sbozzolo
Copy link
Member

(This is not really an issue, more of a consideration.)

The post_{implicit, explicit}! functions are called with signature: (u, p, t). Therefore, if the post_ function wants to use the value of the timestep dt, that has to be included in p. Now, in my opinion, this is a bit dissatisfying because I think that the integrator should own dt and be responsible for it. Hard-coding dt in p introduces a potential mode of failure in which the dt in the integrator and the dt in p disagree on the value of the timestep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant