Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RT in land models #898

Open
kmdeck opened this issue Oct 29, 2024 · 1 comment
Open

Refactor RT in land models #898

kmdeck opened this issue Oct 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kmdeck
Copy link
Member

kmdeck commented Oct 29, 2024

  1. We duplicate a lot of code between the soil_canopy model and the land model in the function lsm_radiant_energy_fluxes
  2. Since soil albedo is a function of moisture, it gets updated in update_aux! for soil. There is no guarantee that this happens before the canopy model computes the two stream update. We need to move all RT into boundary_fluxes. This requires also moving GPP computation and other fluxes that depend on APAR.
  3. We cannot do step 1 until we address Issue Sign consistency with R_n #827. step 1 can happen independently of step 2.
  4. moving away from molar flux Compute surface albedo correctly #851 will make step 1 easier too
@kmdeck kmdeck added the enhancement New feature or request label Oct 29, 2024
@kmdeck
Copy link
Member Author

kmdeck commented Oct 29, 2024

@Espeer5 since this may affect the two band -> multi band work you are working on

@kmdeck kmdeck self-assigned this Oct 29, 2024
@kmdeck kmdeck mentioned this issue Oct 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant