Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land surface albedo #845

Open
kmdeck opened this issue Oct 10, 2024 · 0 comments · May be fixed by #851
Open

Land surface albedo #845

kmdeck opened this issue Oct 10, 2024 · 0 comments · May be fixed by #851
Labels
enhancement New feature or request
Milestone

Comments

@kmdeck
Copy link
Member

kmdeck commented Oct 10, 2024

We currently define land surface albedo to be SW_u/SW_d. At night, SW_d is zero, so albedo is not be defined. This is not physical.

Note that SW_u is proportional to SW_d, so our temporary solution is SW_u/max(SW_d, eps(FT)). This would give zero albedo at night and prevent dividing by zero, but it is still not physical.

We should save the fraction of light absorbed by the land surface and fraction reflected, rather than absolute amount absorbed and reflected. Then the fraction of light reflect = albedo, and we avoid dividing by SW_d.

cc @braghiere

@kmdeck kmdeck added the enhancement New feature or request label Oct 10, 2024
@kmdeck kmdeck added this to the O2.3.8 milestone Oct 10, 2024
@kmdeck kmdeck linked a pull request Oct 14, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant