Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python dependency issues with Python 3.12 and add to docs #319

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Sep 6, 2024

Purpose

Closes #317

Content

  • update buildkite and testing to Python 3.12-compatible scipy (v1.14.1) and scikitlearn (v1.5.1)
  • removed matplotlib (we do not need this?)
  • add this update and other installation help in docs page

  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (acf1051) to head (434413e).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   88.17%   88.57%   +0.40%     
==========================================
  Files           8        8              
  Lines        1184     1217      +33     
==========================================
+ Hits         1044     1078      +34     
+ Misses        140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar
Copy link
Collaborator Author

odunbar commented Sep 6, 2024

tests and buildkite now all pass, docs look good.

@odunbar odunbar merged commit db593be into main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation instructions - add common error
1 participant