Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate emulator comparison examples, and add docs pages for them. #257

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Nov 13, 2023

Purpose

Closes #254
Closes #259

SEE DOCS DEPLOYMENT HERE under Examples->Emulator testing -> ...

Content

  • Removed strict=true in make.jl,
  • Condense the RandomFeature/ and GaussianProcess/ examples for regression into one case Regression_2d_2d
  • rm CI tests for removed examples.
  • Add results figures into docs/src/assets from current runs of the examples
  • Written walkthrough documentation for the Emulator/ cases: Ishigami, Regression_2d_2d, L63 in the style of this

(PS it may look like a lot of files are changed but a bunch are just images for the documentation, and moving the RF + GP examples into 1 file)


  • I have read and checked the items on the review checklist.

@odunbar odunbar force-pushed the orad/docs-emulated branch 3 times, most recently from 6bbb12f to 7b7f46f Compare November 17, 2023 00:02
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a621a04) 88.09% compared to head (f840f34) 88.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   88.09%   88.16%   +0.07%     
==========================================
  Files           7        7              
  Lines        1134     1124      -10     
==========================================
- Hits          999      991       -8     
+ Misses        135      133       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

added new empty docs pages for emulator examples\

format

typo

change buildkite to new examples

regression figures

some example figures from l63

update buildkite

ishigami plots

format

write regression walkthrough alongside example

revisions

fig resizing

format

html to resize images

similar sizing

sizing cont

add quote

lorenz docs

formatter

docs fix

add ../ in regression

added ../

bulk test for ishigami page

ref for GSA

typos

rm breaking buildkite test

remove accidental file

copy optimizer options when doing repeats as they may be modified
@odunbar odunbar changed the title [WIP] Consolidate emulator comparison examples, and add docs pages. Consolidate emulator comparison examples, and add docs pages for emulator-only examples. Nov 18, 2023
@odunbar odunbar changed the title Consolidate emulator comparison examples, and add docs pages for emulator-only examples. Consolidate emulator comparison examples, and add docs pages for them. Nov 18, 2023
@odunbar
Copy link
Collaborator Author

odunbar commented Dec 5, 2023

No review after repeated requests. All tests/builds pass.
As this PR is primarily docs, and changes to docs/make.jl, to help others I will merge now, we can make additional edits to the pages after if required.

@odunbar odunbar merged commit f3edd01 into main Dec 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove strict = true to build docs Write consistent docs pages for Emulator comparison examples
1 participant