Swift Build Fails

[ravelasquez99]

It seems this package cannot be added once you update beyond swift 5.

Repro:

1. Create a library that uses this package. Example: https://pastebin.com/2WEZxsHm . This example uses Vapor but it is also repoduceable on a simple client side package (to get this package run vapor new SECP256k1issue locally in a new repo. Then add the secp256k1 package
2. Make sure your swift version is > 5.1. Run swift --version to confirm
3. Run swift build from the folder that contains the package.

Notice the error: https://pastebin.com/ad9WVhsL

[ravelasquez99]

Update. I pinged the folks in the Swift Package manager slack. They said...

It looks as if the sources: ["."] in the package manifest of the package is causing every file in that directory to be treated as a source file. That line has been in the manifest for a while, so that could be a bug in Swift 5. I don’t know if that was a deliberate change in behavior for swift-tools-version:5.0 packages, but even if it were, it doesn’t seem that the dependency should be treated that way, since it is declaring itself as 4.0

Still pending more comments from them, but I think we may be able to fix this by updating this line to point to a nested folder instead (

secp256k1.swift/Package.swift

Line 47 in 823281f

".",

)

[ravelasquez99]

I also confirmed this happened between Swift 5.1->5.2.2. As it does not repro on Swift 5.1

[koraykoska]

@ravelasquez99 Thanks for identifying this issue. But I don't understand what exactly causes the issue. Is it really the "."? Changing it to a subfolder and moving all the files just works? Could you give it a try and make a PR if it works?

[koraykoska]

You would only have to move the files secp256k1-config.h, secp256k1_ec_mult_static_context.h and secp256k1_main.h to a headers subfolder and change the "." to "headers". If this is the issue...

[koraykoska]

For me the error seems more like the compiler is trying to compile non source files. In which case I do really hope they support regex paths already as it would really be painful including all files manually...

[koraykoska]

@ravelasquez99 I can build the library. Please close this issue unless it persists with current Swift versions.