-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# for namespace properties should be optional #4
Comments
@pdpark what is the problem cause by the current behavior? |
I agree with this. When you supply a # in the property namespace you get a weird error and it takes a while until you figure out that you have to remove the #. I also find it rather unintuitive; if you supply a namespace, you don't expect modifications. What's the reason you designed it like this? |
OK, I can see We should be careful about the terms "base URI" vs. "namespace" though, as those can lead to different behavior:
Not a great example, but based on this issue I think what we want here is the namespace, not base URI. I'm not even sure it's legal for base URI to have |
Oh, why is that?
Sure, but that's the user's concern, no? I see two options: 1) a warning that URIs will be weird if the supplied namespace does not end with
If it's not allowed, it should be in https://tools.ietf.org/html/rfc3986#section-5.2 (can't tell at this point) Since we're talking about a namespace, a nice-to-have is adding it as |
Resolving against base URI follows general URI resolution: System.out.println(java.net.URI.create("https://localhost/some/ns").resolve("property").toString()); returns
Yes it is a user's concern. In this case namespace and local name are simply concatenated. I'd rather not put any restrictions on that. I will refactor this to be a namespace thing rather than a base URI thing. So the Now I wonder how CSV2RDF should be aligned with this... |
From the README: "Property namespace is constructed by adding # to the base URI."
If the base URI ends in a forward slash (/), a pound/number sign (#) should not be added to the base URI.
The text was updated successfully, but these errors were encountered: