RE: Bump HikariCP from 3.2.0 to 3.3.1

[jhejderup]

#5
Bumps com.zaxxer:HikariCP from 3.2.0 to 3.3.1. This update introduces changes in 50 existing functions: 25 of those functions are called by 3 function(s) in this project and has the risk of creating potential regression errors. We advise you to review these changes before merging the pull request.

Below are project functions that will be impacted after the update:

• 
  Sample Affected Path(s)

  com.greatmancode.craftconomy3.utils.OldFormatConverter.run
  
        at: com.zaxxer.hikari.HikariConfig.setDriverClassName
  
  

  Changed Dependency Function(s)

  • 
    • Update Invocation in Try (L501) to Try (L489)
    • Delete Literal in LocalVariable (L474)
    • Delete Assignment in Try (L479)
    • Delete LocalVariable in Method (L475)
    • Insert Invocation in LocalVariable (L474)
    • Move VariableRead in Invocation (L501) to Invocation (L489)
• 
  Sample Affected Path(s)

  com.greatmancode.craftconomy3.storage.sql.SQLStorageEngine.getAccount
  
        at: com.zaxxer.hikari.HikariDataSource.getConnection
  
        at: com.zaxxer.hikari.HikariConfig.validate
  
        at: com.zaxxer.hikari.HikariConfig.validateNumerics
  
  

  com.greatmancode.craftconomy3.storage.sql.SQLStorageEngine.getAccount
  
        at: com.greatmancode.tools.utils.Tools.closeJDBCConnection
  
        at: com.zaxxer.hikari.pool.ProxyConnection.close
  
        at: com.zaxxer.hikari.pool.PoolEntry.resetConnectionState
  
        at: com.zaxxer.hikari.pool.PoolBase.resetConnectionState
  
  

  com.greatmancode.craftconomy3.storage.sql.SQLStorageEngine.getAccount
  
        at: com.zaxxer.hikari.HikariDataSource.getConnection
  
        at: com.zaxxer.hikari.pool.HikariPool.<init>
  
        at: com.zaxxer.hikari.pool.PoolBase.registerMBeans
  
        at: com.zaxxer.hikari.HikariConfig.isRegisterMbeans
  
  

  Changed Dependency Function(s)

  • 
    • Update Invocation in If (L1008) to If (L1009)
    • Delete If in Method (L977)
    • Delete If in Method (L972)
    • Delete Conditional in Assignment (L1000)
    • Insert If in Method (L1000)
    • Move FieldRead in Assignment (L1000) to If (L1004)
    • Move BinaryOperator in If (L977) to If (L1004)
    • Move FieldRead in Assignment (L1000) to Assignment (L993)
    • Move FieldRead in Assignment (L1000) to If (L1000)
    • Move BinaryOperator in If (L972) to If (L1000)
    • ... 3 more AST change(s)
  • 
    • Delete Annotation in Method (L761)
  • 
    • Update FieldRead in Invocation (L235) to Invocation (L238)
    • Update FieldRead in Invocation (L236) to Invocation (L239)
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
  • 
• 
  Sample Affected Path(s)

  com.greatmancode.craftconomy3.storage.sql.SQLStorageEngine.getAccount
  
        at: com.zaxxer.hikari.pool.HikariProxyPreparedStatement.getGeneratedKeys
  
        at: com.zaxxer.hikari.pool.ProxyStatement.getGeneratedKeys
  
  

  Changed Dependency Function(s)

  • 
    • Delete If in Method (L231)
    • Move If in If (L232) to Method (L231)

---

Did you find this information useful? Give this issue a 👍 if it is useful, 👎 if it is not, and ✋ if neutral.

Want to help us or have suggestions?

We are a group of university researchers trying to make automated dependency services more useful and user-friendly for OSS projects. If you have feedback and questions about this, feel free to submit it here.